Conversation
|
|
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
Member
|
Let's wait a bit with this one, asking for feedback about when WebContainers will move to Node 18. I tried codeflow and it works apart from a few warnings so we could also merge it before we release the first alpha/beta. |
Member
|
If we bump to 18.4.0, we can simplify this part. vite/packages/vite/src/node/utils.ts Lines 924 to 926 in 6cb397f (Because it will include nodejs/node#43054) That said, I think it's fine going with 18.0.0 as this is a tiny one. |
9 tasks
Member
|
The version in StackBlitz should be updated after Node 16 EOL, let's move forward with this one. It stills works, there is only a warning. I already removed node-14 and node-16 from the test matrix. |
patak-cat
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump the packages in this monorepo to require minimum node 18. Not sure if we need to bump to a specific minor version of 18, currently have it at 18.0.0
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).