[Misc] feature(rayclusterreplicaset): check rayclusters crd is installed before controller start #922
Conversation
|
some check from here (not sure if correct?): https://github.com/ray-project/kuberay/blob/master/ray-operator/config/crd/bases/ray.io_rayclusters.yaml |
|
another way: we can check in helm like this: InftyAI/llmaz#316 (comment) |
| // TODO: check crd exists or not. If not, we should fail here directly without moving forward. | ||
| // This is used to validate whether kuberay is installed now. | ||
| // Check if the CRD exists. If not, fail directly. | ||
| crdName := "rayclusters.ray.io" |
There was a problem hiding this comment.
This is a hard code, not sure if it is good enough
There was a problem hiding this comment.
this is ok for short term but better to use scheme to construct it
There was a problem hiding this comment.
🤔 In addition to the ray dependency, do we also need to do the same for the EnvoyGateway object?
There was a problem hiding this comment.
Do you find anywhere suitable for the EnvoyGateway object check? Without it, the load balancer won’t be populated. Adding checks could help catch the issue earlier, but the failure would still be visible even without them.
There was a problem hiding this comment.
Do you find anywhere suitable for the
EnvoyGatewayobject check? Without it, the load balancer won’t be populated. Adding checks could help catch the issue earlier, but the failure would still be visible even without them.
Sounds reasonable, we can find this problem again when creating envoy-gateway-config. 🤔
|
maybe this ci failed is no install ray error 🤔 : https://github.com/vllm-project/aibrix/actions/runs/14151203937/job/39644648825?pr=922 |
googs1025
force-pushed
the
add_ray_crd_first
branch
from
f33457e to
aab6d8d
Compare
|
@googs1025 you mean the ci failure is due to ray crd dependency? Let me double check if that's related to this change #793 |
oh, I mistakenly thought that there was no dependency installed. |
|
@googs1025 the problem is controller-manager lack of permission to get/list crds. Please help grant the permission in this PR. |
…ore controller start Signed-off-by: googs1025 <[email protected]>
googs1025
force-pushed
the
add_ray_crd_first
branch
from
aab6d8d to
a0cd509
Compare
thanks for this. done |
…led before controller start (vllm-project#922) feature(rayclusterreplicaset): check rayclusters crd is installed before controller start Signed-off-by: googs1025 <[email protected]>
…led before controller start (vllm-project#922) feature(rayclusterreplicaset): check rayclusters crd is installed before controller start Signed-off-by: googs1025 <[email protected]>
2 participants
Pull Request Description
[Please provide a clear and concise description of your changes here]
Related Issues
Resolves: #[Insert issue number(s)]None
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.