-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
[Bugfix][ROCm] Fix import error on ROCm #17495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gregory Shtrasberg <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, my bad..
Signed-off-by: Gregory Shtrasberg <[email protected]>
Signed-off-by: Gregory Shtrasberg <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Signed-off-by: Gregory Shtrasberg <[email protected]> Signed-off-by: Yuqi Zhang <[email protected]>
Signed-off-by: Gregory Shtrasberg <[email protected]> Signed-off-by: minpeter <[email protected]>
Fix regression added in #17435
from vllm.vllm_flash_attn.layers.rotary import apply_rotary_emb
does not apply to ROCm, it results in