Skip to content

FIxing the AMD test failures caused by PR#16457 #17511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2025
Merged

FIxing the AMD test failures caused by PR#16457 #17511

merged 2 commits into from
May 1, 2025

Conversation

Alexei-V-Ivanov-AMD
Copy link
Collaborator

@Alexei-V-Ivanov-AMD Alexei-V-Ivanov-AMD commented May 1, 2025 •
edited by github-actions bot
Loading

FIxing the AMD test failures caused by PR#16457

@Alexei-V-Ivanov-AMD
TESTING MAIN 20250430
70a4b8c 
TESTING MAIN 20250430

Signed-off-by: Alexei V. Ivanov <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label May 1, 2025
@Alexei-V-Ivanov-AMD
Fixing is_cuda_alike usage.
e115237 
Signed-off-by: Alexei V. Ivanov <[email protected]>
@Alexei-V-Ivanov-AMD Alexei-V-Ivanov-AMD changed the title TESTING MAIN 20250430 FIxing the AMD test failures caused by PR#16457 May 1, 2025
houseroad
houseroad reviewed May 1, 2025
View reviewed changes
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase after #17495?

Also can be add a test to cover this case?

@houseroad houseroad added the rocm Related to AMD ROCm label May 1, 2025
@Alexei-V-Ivanov-AMD
Copy link
Collaborator Author

#17495 has fixed only L35. L83 remains not changed to its proper state.

Also can be add a test to cover this case?

Will definitely think about it.

DarkLight1337
DarkLight1337 approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this first to unblock

@vllm-bot vllm-bot merged commit 7ab643e into vllm-project:main May 1, 2025
19 of 22 checks passed
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
@Alexei-V-Ivanov-AMD @radeksm
FIxing the AMD test failures caused by PR#16457 (vllm-project#17511)
a00056d 
Signed-off-by: Alexei V. Ivanov <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@Alexei-V-Ivanov-AMD
FIxing the AMD test failures caused by PR#16457 (vllm-project#17511)
71b812e 
Signed-off-by: Alexei V. Ivanov <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@Alexei-V-Ivanov-AMD
FIxing the AMD test failures caused by PR#16457 (vllm-project#17511)
55ee9c8 
Signed-off-by: Alexei V. Ivanov <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@Alexei-V-Ivanov-AMD @minpeter
FIxing the AMD test failures caused by PR#16457 (vllm-project#17511)
e7dee6c 
Signed-off-by: Alexei V. Ivanov <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houseroad houseroad houseroad left review comments

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ci/build rocm Related to AMD ROCm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alexei-V-Ivanov-AMD @houseroad @DarkLight1337 @vllm-bot