Skip to content

skip InternS1ForConditionalGeneration for test_can_initialize_large_s… - #25633

Closed
hl475 wants to merge 1 commit into
vllm-project:mainfrom
hl475:InternS1ForConditionalGeneration
Closed

hl475 wants to merge 1 commit into
vllm-project:mainfrom
hl475:InternS1ForConditionalGeneration

Conversation

@hl475

@hl475 hl475 commented Sep 25, 2025 •

Copy link
Copy Markdown
Contributor

Purpose

Looking the nightly build CI in the past few days https://app.hex.tech/533fe68e-dcd8-4a52-a101-aefba762f581/app/vLLM-CI-030kdEgDv6lSlh1UPYOkWP/latest , i found that tests/models/test_initialization.py::test_can_initialize_large_subset[InternS1ForConditionalGeneration] kept failing with the error like


[2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708] EngineCore failed to start.
--
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708] Traceback (most recent call last):
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708]   File "/usr/local/lib/python3.12/dist-packages/vllm/inputs/registry.py", line 166, in call_hf_processor
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708]     output = hf_processor(**data,
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708]              ^^^^^^^^^^^^^^^^^^^^
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708]   File "/usr/local/lib/python3.12/dist-packages/transformers/models/internvl/processing_internvl.py", line 224, in __call__
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708]     video_inputs = self.video_processor(videos=videos, **output_kwargs["videos_kwargs"])
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708]                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708]   File "/usr/local/lib/python3.12/dist-packages/transformers/video_processing_utils.py", line 209, in __call__
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708]     return self.preprocess(videos, **kwargs)
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708]   File "/usr/local/lib/python3.12/dist-packages/transformers/video_processing_utils.py", line 390, in preprocess
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708]     preprocessed_videos = self._preprocess(videos=videos, **kwargs)
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708]                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  | [2025-09-24T04:18:47Z] (EngineCore_DP0 pid=3162) ERROR 09-23 21:18:47 [core.py:708] TypeError: InternS1VideoProcessor._preprocess() got an unexpected keyword argument 'pad_size'

sample job link https://buildkite.com/vllm/ci/builds/32227/steps/canvas?sid=019979e1-da27-4a3e-b27f-f9618b32c93b

we might want to skip this particular test to make all the test good for all the other models otherwise it is flaky and lose the point of testing

i found one similar issue reported on hf transformer side huggingface/transformers#41079 and i will create a new issue

Test Plan

CI

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

…ubset

Signed-off-by: Huamin Li <3ericli@gmail.com>
@hl475
hl475 marked this pull request as ready for review September 25, 2025 04:08
@DarkLight1337

Copy link
Copy Markdown
Member

cc @Isotr0py I remember this problem comes from HF side, can you follow up on that?

@Isotr0py

Copy link
Copy Markdown
Member

I see, let me port the video processor from huggingface/transformers#39722 before it merged into Transformers.

@Isotr0py

Copy link
Copy Markdown
Member

#25644 should fix the failing CI

@DarkLight1337

Copy link
Copy Markdown
Member

Closing as superseded by #25644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants