Repository navigation
[Bugfix] Fix InternS1 video processing after Transformers v4.56 - #25644
Merged
Merged
Conversation
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a fix for InternS1 model initialization by adding utility functions to load video processors, similar to how image processors are handled. The changes are generally good and follow existing patterns in the codebase. However, I've found a minor issue in the newly added get_video_processor function where an error message was copied from the image processor equivalent and not updated, which could lead to user confusion.
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Isotr0py
changed the title
5 tasks
DarkLight1337
added
the
ready
Member
|
The test for InternS1 passes, but now GLM4.5V fails again |
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
DarkLight1337
approved these changes
Sep 25, 2025
DarkLight1337
enabled auto-merge (squash)
September 25, 2025 10:31
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: yewentao256 <zhyanwentao@126.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…-project#25644) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
ptrdlr14
pushed a commit
to ptrdlr14/vllm
that referenced
this pull request
Oct 20, 2025
…-project#25644) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…-project#25644) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…-project#25644) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…-project#25644) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…-project#25644) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: yewentao256 <zhyanwentao@126.com>
0826joyce
pushed a commit
to 0826joyce/vllm-serving-optimization
that referenced
this pull request
May 19, 2026
…-project#25644) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
…-project#25644) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.