Dotenv: Unused Loader instance in __construct #210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadData() will always create a Loader instance, so creating one in Dotenv::__construct() is only useful because it is currently required for Validate to work before calling load() on a real file.
|
Hmm. Not sure this is the best fix actually. |
|
I think we have a more fundamental design problem here. |
|
Completely agree that this is not the best fix. This only makes it more clear what is happening whereas right now, it's somewhat misleading. Feel free to close this out when you have a better solution. If you can, please link to that better solution here. |
|
Just merged #215 which fixes this problem in |
|
Thanks @vlucas, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadData() will always create a Loader instance, so creating one in Dotenv::__construct() is only useful for Validate.
Hopefully travis agrees.