[2.5] Remove double instantiation of loader class #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add set & get immutable method in loader class add tests for set & get immutable method
|
Thanks for this. 👍 |
|
I'm not sure we should allow modification of the immutability of the loader. 👎 on this. Kinda defeats the point of making it immutable if we allow that flag to be mutated. |
arifmahmudrana
deleted the
remove-double-instantiation-loader-class-and-add-set-immutable-method
branch
arifmahmudrana
restored the
remove-double-instantiation-loader-class-and-add-set-immutable-method
branch
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add set & get immutable method in loader class
add tests for set & get immutable method