Skip to content

[2.5] Fix variable values starting with hash are being converted into empty strings #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Korbeil
Copy link
Contributor

@Korbeil Korbeil commented Jul 2, 2018

Fixes #276

Copy link

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@GrahamCampbell GrahamCampbell merged commit 8abb4f9 into vlucas:master Jul 29, 2018
@GrahamCampbell GrahamCampbell changed the title 276 variable values starting with are being converted into empty strings [2.5] Fix variable values starting with hash are being converted into empty strings Jan 28, 2019
@GrahamCampbell
Copy link
Collaborator

NB The behaviour here has been changed in 3.x so that unquoted variables starting with a hash are now considered to be empty, as they will be parsed as comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants