Reuse vCenter and NSX manager for tests #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
Signed-off-by: Dainius <[email protected]>
lvirbalas
approved these changes
Mar 21, 2025
lvirbalas
left a comment
lvirbalas
left a comment
There was a problem hiding this comment.
This great and contains everything we already discussed offline. Thanks!
Signed-off-by: Dainius <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to reuse vCenter and NSX manager across many tests that depend on it.
This functionality should remove dependency of creating/destroying NSX/vCenter in every test that requires it and improve reliability and performance this way.
It leverages
preTestChecksandpostTestChecksto ensure that whatever test is run, it would execute the priority tests at first and then setup shared NSX + vCenter for usage in further tests that is only cleaned up at the very end of suite.