Skip to content

Allow ESLint v10 as peer dependency #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ota-meshi merged 8 commits into from
Feb 13, 2026
Merged

Allow ESLint v10 as peer dependency #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8928b15
Allow ESLint v10 as peer dependency
FloEdelmann Jan 13, 2026
e16b8a7
Don't cancel other jobs if one fails
FloEdelmann Feb 11, 2026
3a77d61
Restrict AST tests to ESLint <10
FloEdelmann Feb 11, 2026
d5544fb
Copy AST tests for ESLint v10
FloEdelmann Feb 11, 2026
6002782
Restrict new AST tests to ESLint >=10
FloEdelmann Feb 11, 2026
951923c
Update ESLint v10 AST snapshots
FloEdelmann Feb 11, 2026
4ff653c
Turn off babel AST test for ESLint v10
FloEdelmann Feb 11, 2026
6f535a3
Skip babel-eslint tests on ESLint v10
FloEdelmann Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 5 additions & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
test:
name: Test
strategy:
fail-fast: false
matrix:
eslint: [9]
node: [18, 20, 21, 'lts/*']
Expand All @@ -40,7 +41,10 @@ jobs:
- eslint: 9
node: 'lts/*'
os: macos-latest

# newer ESLint version
- eslint: 10
node: 'lts/*'
os: 'ubuntu-latest'
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
Expand Down
14 changes: 7 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,19 @@
"node": "^18.18.0 || ^20.9.0 || >=21.1.0"
},
"peerDependencies": {
"eslint": "^8.57.0 || ^9.0.0"
"eslint": "^8.57.0 || ^9.0.0 || ^10.0.0"
},
"dependencies": {
"debug": "^4.4.0",
"eslint-scope": "^8.2.0",
"eslint-visitor-keys": "^4.2.0",
"espree": "^10.3.0",
"eslint-scope": "^8.2.0 || ^9.0.0",
"eslint-visitor-keys": "^4.2.0 || ^5.0.0",
"espree": "^10.3.0 || ^11.0.0",
"esquery": "^1.6.0",
"semver": "^7.6.3"
},
"devDependencies": {
"@babel/core": "^7.26.7",
"@babel/eslint-parser": "^7.26.5",
"@babel/eslint-parser": "^7.28.6",
"@babel/plugin-syntax-decorators": "^7.25.9",
"@babel/plugin-syntax-pipeline-operator": "^7.26.7",
"@babel/plugin-syntax-typescript": "^7.25.9",
Expand All @@ -37,8 +37,8 @@
"@types/estree": "^1.0.0",
"@types/node": "^18.8.4",
"@types/semver": "^7.3.12",
"@typescript-eslint/eslint-plugin": "^8.22.0",
"@typescript-eslint/parser": "^8.22.0",
"@typescript-eslint/eslint-plugin": "^8.55.0",
"@typescript-eslint/parser": "^8.55.0",
"@vitest/coverage-v8": "^3.2.4",
"@vitest/ui": "^3.2.4",
"eslint": "^9.19.0",
Expand Down
13 changes: 11 additions & 2 deletions scripts/ci-install-eslint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,19 @@ function sh(command) {
? requestedVersion
: `^${requestedVersion}`

const packageVersions = [`eslint@${requestedVersionSpec}`]

if (requestedVersion === "10") {
packageVersions.push("espree@11", "eslint-scope@9")
} else if (Number(requestedVersion) < 10) {
packageVersions.push("espree@10", "eslint-scope@8")
}

// Install ESLint of the requested version
await sh(`npm install eslint@${requestedVersionSpec} -f`)
if (Number(requestedVersion) < 9)
await sh(`npm install ${packageVersions.join(" ")} -f`)
if (Number(requestedVersion) < 9) {
await sh(`npm install @types/eslint -D -f`)
}

// Install ESLint submodule of the requested version
// const installedVersion = require("eslint/package.json").version
Expand Down
Loading