Skip to content

fix: breaking change - sfbutton padding size #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aniamusial merged 2 commits into from
Jun 14, 2023
Merged

fix: breaking change - sfbutton padding size #2815

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4edffda
chore: added changeset for button size
aniamusial Jun 13, 2023
7f63a2c
chore: added changeset
aniamusial Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/flat-birds-grab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@storefront-ui/react': patch
'@storefront-ui/vue': patch
Copy link
Copy Markdown
Contributor

@FRSgit FRSgit Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no - this changeset should contain major bump with breaking changes 😄

---

Adjustments to padding size for rounded variant of SfButton
2 changes: 1 addition & 1 deletion packages/sfui/frameworks/react/components/SfButton/SfButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const getSizeClasses = (size: SfButtonProps['size'], square: SfButtonProps['squa
case SfButtonSize.sm:
return [square ? 'p-1.5' : 'leading-5 text-sm py-1.5 px-3', 'gap-1.5'];
case SfButtonSize.lg:
return [square ? 'p-4' : 'py-3 leading-6 px-6', 'gap-3'];
return [square ? 'p-3' : 'py-3 leading-6 px-6', 'gap-3'];
default:
return [square ? 'p-2' : 'py-2 leading-6 px-4', 'gap-2'];
}
Expand Down
2 changes: 1 addition & 1 deletion packages/sfui/frameworks/vue/components/SfButton/SfButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const sizeClasses = computed(() => {
case SfButtonSize.sm:
return [square.value ? 'p-1.5' : 'leading-5 text-sm py-1.5 px-3', 'gap-1.5'];
case SfButtonSize.lg:
return [square.value ? 'p-4' : 'py-3 leading-6 px-6', 'gap-3'];
return [square.value ? 'p-3' : 'py-3 leading-6 px-6', 'gap-3'];
default:
return [square.value ? 'p-2' : 'py-2 leading-6 px-4', 'gap-2'];
}
Expand Down