fix: breaking change - sfbutton padding size #2815
Merged
aniamusial merged 2 commits intov2-release/3.0.0from Jun 14, 2023
Merged
fix: breaking change - sfbutton padding size #2815aniamusial merged 2 commits intov2-release/3.0.0from
aniamusial merged 2 commits intov2-release/3.0.0from
Conversation
🦋 Changeset detectedLatest commit: 7f63a2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aniamusial
requested review from
FRSgit,
Szymon-dziewonski,
dkacper and
mattmaribojoc
as code owners
FRSgit
reviewed
Jun 13, 2023
Comment on lines
+2
to
+3
| '@storefront-ui/react': patch | ||
| '@storefront-ui/vue': patch |
Contributor
There was a problem hiding this comment.
Oh, no - this changeset should contain major bump with breaking changes 😄
FRSgit
approved these changes
Jun 14, 2023
|
[storefront-ui-react] Kudos, SonarCloud Quality Gate passed! |
|
[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed! |
Szymon-dziewonski
pushed a commit
that referenced
this pull request
Jun 14, 2023
* chore: added changeset for button size * chore: added changeset
FRSgit
pushed a commit
that referenced
this pull request
Jun 27, 2023
FRSgit
pushed a commit
that referenced
this pull request
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
https://vsf.atlassian.net/browse/SFUI2-1066?atlOrigin=eyJpIjoiMmNkZDU2MDgwMjY4NDVlM2E5MWNkMDRiNDNkMzExYmIiLCJwIjoiaiJ9
Scope of work
Screenshots of visual changes
Checklist