Skip to content

fix: breaking change - sfbutton padding size (#2815)#2829

Merged
FRSgit merged 1 commit intov2-developfrom
v2-release/3.0.0
Jun 27, 2023
Merged

fix: breaking change - sfbutton padding size (#2815)#2829
FRSgit merged 1 commit intov2-developfrom
v2-release/3.0.0

Conversation

@aniamusial
Copy link
Copy Markdown
Contributor

@aniamusial aniamusial commented Jun 15, 2023 •
edited
Loading

Related issue

https://vsf.atlassian.net/browse/SFUI2-1226?atlOrigin=eyJpIjoiNjVhNTc3NjNlYWYyNGZiZDllMmYxZTcwYjk1NGRiZWUiLCJwIjoiaiJ9

Scope of work

  • changed padding right from 14px to 12px

Screenshots of visual changes

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@aniamusial @Szymon-dziewonski
fix: breaking change - sfbutton padding size (#2815)
3669683 
* chore: added changeset for button size

* chore: added changeset
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 15, 2023

🦋 Changeset detected

Latest commit: 3669683

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@storefront-ui/react Major
@storefront-ui/vue Major
@storefront-ui/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aniamusial aniamusial marked this pull request as ready for review June 15, 2023 08:10
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 15, 2023

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 15, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

1 similar comment
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 15, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 15, 2023

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@FRSgit FRSgit merged commit f71e9b4 into v2-develop Jun 27, 2023
@FRSgit FRSgit deleted the v2-release/3.0.0 branch June 27, 2023 13:52
FRSgit pushed a commit that referenced this pull request Jun 29, 2023
@aniamusial @FRSgit
fix: breaking change - sfbutton padding size (#2815) (#2829)
33935c6
@AdamPawlinski AdamPawlinski mentioned this pull request Jul 4, 2023
Merged
MaciejWolowski added a commit that referenced this pull request Jul 4, 2023
@MaciejWolowski @aniamusial
feat: add e2e code preview check (#2890)
395948b 
* fix: breaking change - sfbutton padding size  (#2815) (#2829)

* feat: add e2e test for code preview checking in the docs

* Update SfButton.tsx

* Update SfButton.vue

* Delete five-geese-serve.md

---------

Co-authored-by: Anna Musial <ania.musial13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRSgit FRSgit FRSgit approved these changes

@Szymon-dziewonski Szymon-dziewonski Awaiting requested review from Szymon-dziewonski Szymon-dziewonski is a code owner

@dkacper dkacper Awaiting requested review from dkacper

@mattmaribojoc mattmaribojoc Awaiting requested review from mattmaribojoc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aniamusial @FRSgit