-
Notifications
You must be signed in to change notification settings - Fork 34
Create Term Definition algorithm, possible imprecision step 11 #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, it should set the |
This issue was discussed in a meeting.
View the transcriptRob Sanderson: #475Rob Sanderson: This issue is a micro-tweak to the algorithms. Gregg Kellogg: The API document does not explicitly handle @Protected: false cases. … I believe this change is editorial. Rob Sanderson: The change to the text should be very small. … This is a change to a normative section that we have previously decided is editorial, because the tests aren’t changed. So we should fix this if we are comfortable given the transition request. Ivan Herman: Does it affect any implementation already out there? I assume not. Rob Sanderson: If you implemented strictly, you would fail the test. So this change is required to make implementations pass the test. Proposed resolution: Make editorial fix for @Protected in Create Term Definition algorithm per api #475 (Rob Sanderson) Gregg Kellogg: +1 Rob Sanderson: +1 Ruben Taelman: +1 David I. Lehn: +1 Pierre-Antoine Champin: +1 Ivan Herman: +1 Resolution #2: Make editorial fix for @Protected in Create Term Definition algorithm per api #475 Benjamin Young: +1 |
gkellogg
added a commit
that referenced
this issue
Apr 27, 2020
…olean value of `@protected`, not just `true`. Fixes #475.
Merged
@timothee-haudebourg This is fixed in #481. Please let us know if that satisfies your concern. |
It satisfies my concern, thanks. |
gkellogg
added a commit
that referenced
this issue
Apr 29, 2020
…olean value of `@protected`, not just `true`. Fixes #475.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Step 11 of the Create Term Definition Algorithm, it is said that
Strictly following this, a
"@protected": false
in a term definition is ignored.However, this makes the expansion test
pr13
to fail.The text was updated successfully, but these errors were encountered: