Skip to content

Create Term Definition algorithm, possible imprecision step 11 #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timothee-haudebourg opened this issue Apr 19, 2020 · 4 comments · Fixed by #481
Closed

Create Term Definition algorithm, possible imprecision step 11 #475

timothee-haudebourg opened this issue Apr 19, 2020 · 4 comments · Fixed by #481

Comments

@timothee-haudebourg
Copy link

Step 11 of the Create Term Definition Algorithm, it is said that

If the @protected entry in value is true set the protected flag in definition to true

Strictly following this, a "@protected": false in a term definition is ignored.
However, this makes the expansion test pr13 to fail.

@gkellogg
Copy link
Member

Yes, it should set the protected flag to the value of the @protected entry, not only if it is true.

@iherman
Copy link
Member

iherman commented Apr 24, 2020

This issue was discussed in a meeting.

  • RESOLVED: Make editorial fix for @protected in Create Term Definition algorithm per api #475
View the transcript Rob Sanderson: #475
Rob Sanderson: This issue is a micro-tweak to the algorithms.
Gregg Kellogg: The API document does not explicitly handle @Protected: false cases.
… I believe this change is editorial.
Rob Sanderson: The change to the text should be very small.
… This is a change to a normative section that we have previously decided is editorial, because the tests aren’t changed. So we should fix this if we are comfortable given the transition request.
Ivan Herman: Does it affect any implementation already out there? I assume not.
Rob Sanderson: If you implemented strictly, you would fail the test. So this change is required to make implementations pass the test.
Proposed resolution: Make editorial fix for @Protected in Create Term Definition algorithm per api #475 (Rob Sanderson)
Gregg Kellogg: +1
Rob Sanderson: +1
Ruben Taelman: +1
David I. Lehn: +1
Pierre-Antoine Champin: +1
Ivan Herman: +1
Resolution #2: Make editorial fix for @Protected in Create Term Definition algorithm per api #475
Benjamin Young: +1

gkellogg added a commit that referenced this issue Apr 27, 2020
…olean value of `@protected`, not just `true`.

Fixes #475.
@gkellogg
Copy link
Member

@timothee-haudebourg This is fixed in #481. Please let us know if that satisfies your concern.

@timothee-haudebourg
Copy link
Author

It satisfies my concern, thanks.

gkellogg added a commit that referenced this issue Apr 29, 2020
…olean value of `@protected`, not just `true`.

Fixes #475.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants