Skip to content

Timothee updates #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2020
Merged

Timothee updates #481

merged 6 commits into from
Apr 29, 2020

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Apr 27, 2020


Preview | Diff

…olean value of `@protected`, not just `true`.

Fixes #475.
…e from map parameter to properly manage reverting active contexts.

Fixes #478.
…tive property, as included blocks do not define a relationship to a referencing node.

Fixes #479.
…esult.

Note: toRdf/e122 does not include a triple for this, so it remains normative.

For #480.
@gkellogg gkellogg requested review from pchampin and iherman April 27, 2020 18:52
@gkellogg
Copy link
Member Author

@iherman note that this updates the implementation report which now considers expand/0122 to be non-normative, as the resulting file is not legal JSON-LD.

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to freeze the document now. The Director is reviewing the PR submission (with one issue pending), which means that the text must be frozen as soon as the submission is accepted.

(The Director also looks at the diff between the current /TR version and the last version of the official CR...)

@gkellogg
Copy link
Member Author

@iherman So, does that mean you'd like to back out the change that affects the implementation report, or just be sure it's in prior to acceptance?

@gkellogg
Copy link
Member Author

@iherman: we have agreement on everything, we can pull this PR pending your clarification to changing the implementation report to show the affected test as being non-normative. If you don't want this change, I can back out the commit.

@iherman
Copy link
Member

iherman commented Apr 29, 2020

@gkellogg I am less worried about the implementation report, as long as it does not change our exit criteria results:-). We did agree (and I told the Director) that we intend to add new implementations, for example, to the report. I am worried about the specifications themselves.

I intend to set up the errata page/script for all documents this week. We should begin to use that if needed...

@gkellogg
Copy link
Member Author

@gkellogg I am less worried about the implementation report, as long as it does not change our exit criteria results:-). We did agree (and I told the Director) that we intend to add new implementations, for example, to the report. I am worried about the specifications themselves.

IIRC, we agreed to make these changes to the spec, are you saying we shouldn’t pull the PR now? I’m confused.

@iherman
Copy link
Member

iherman commented Apr 29, 2020

@gkellogg I am less worried about the implementation report, as long as it does not change our exit criteria results:-). We did agree (and I told the Director) that we intend to add new implementations, for example, to the report. I am worried about the specifications themselves.

IIRC, we agreed to make these changes to the spec, are you saying we shouldn’t pull the PR now? I’m confused.

We are talking one another... reset:-) What I mean is:

  • merge this PR, meaning the report as well as the spec gets a minor update
  • no more PR-s on the spec
  • PR-s on the report are o.k. for the future, too.

I am afraid we are in a violent agreement...

@gkellogg
Copy link
Member Author

Okay, thanks!

@gkellogg gkellogg merged commit 753ca11 into master Apr 29, 2020
@gkellogg gkellogg deleted the timothee-updates branch April 29, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants