Conversation
dlongley
approved these changes
Sep 2, 2019
Member
|
This issue was discussed in a meeting.
View the transcriptFraming blank nodesRob Sanderson: last discussion we agreed that we couldn’t solve it on a call … so gkellog and dlongley went off to look at it Gregg Kellogg: we found a problem in a framing test where @container : @graph got mangled in re-expansion… a bug in the compaction algo … if the value is an array, it puts them in an @included block… i tried [s solution] but it turned out not to be defined well enough Rob Sanderson: all of that is solved and merged? Gregg Kellogg: yep Gregg Kellogg: See API PR #146 Gregg Kellogg: See API PR #145 Proposed resolution: Close framing #27 as not being the issue, and the real issues being addressed is api #143, solved by api PRs # 145 and #146 (Rob Sanderson) Rob Sanderson: +1 Benjamin Young: +1 Dave Longley: +1 Gregg Kellogg: +1 Ivan Herman: +1 Adam Soroka: +1 Pierre-Antoine Champin: +1 Ruben Taelman: +1 Rob Sanderson: RESOLVE: Close framing #27 as not being the issue, and the real issues being addressed is api #143, solved by api PRs # 145 and #146 Proposed resolution: Close api #143 as resolved by api PR #145 and #146 (Rob Sanderson) Rob Sanderson: +1 Ivan Herman: +1 Ruben Taelman: +1 Gregg Kellogg: +1 Adam Soroka: +1 Pierre-Antoine Champin: +1 Benjamin Young: +1 Dave Longley: +1 Resolution #2: Close api #143 as resolved by api PR #145 and #146 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ers where the value is already a graph.
Fixes #144. Relates to #143.
Preview | Diff