Skip to content

Wrap multiple object values of a term which is a graph container - #146

Merged
gkellogg merged 1 commit into
masterfrom
issue-143
Sep 3, 2019
Merged

gkellogg merged 1 commit into
masterfrom
issue-143

Conversation

@gkellogg

@gkellogg gkellogg commented Sep 2, 2019 •

Copy link
Copy Markdown
Member

... using @included, to make sure they are all contained in a single graph.

Fixes #143.


Preview | Diff

…g `@included`, to make sure they are all contained in a single graph.

Fixes #143.
@gkellogg
gkellogg requested a review from dlongley September 2, 2019 20:44
@gkellogg
gkellogg merged commit 1812ed9 into master Sep 3, 2019
@gkellogg
gkellogg deleted the issue-143 branch September 3, 2019 05:30
@iherman

iherman commented Sep 6, 2019

Copy link
Copy Markdown
Member

This issue was discussed in a meeting.

  • RESOLVED: Close api #143 as resolved by api PR #145 and #146
View the transcript Framing blank nodes
Rob Sanderson: last discussion we agreed that we couldn’t solve it on a call
… so gkellog and dlongley went off to look at it
Gregg Kellogg: we found a problem in a framing test where @container : @graph got mangled in re-expansion
… a bug in the compaction algo
… if the value is an array, it puts them in an @included block
… i tried [s solution] but it turned out not to be defined well enough
Rob Sanderson: all of that is solved and merged?
Gregg Kellogg: yep
Gregg Kellogg: See API PR #146
Gregg Kellogg: See API PR #145
Proposed resolution: Close framing #27 as not being the issue, and the real issues being addressed is api #143, solved by api PRs # 145 and #146 (Rob Sanderson)
Rob Sanderson: +1
Benjamin Young: +1
Dave Longley: +1
Gregg Kellogg: +1
Ivan Herman: +1
Adam Soroka: +1
Pierre-Antoine Champin: +1
Ruben Taelman: +1
Rob Sanderson: RESOLVE: Close framing #27 as not being the issue, and the real issues being addressed is api #143, solved by api PRs # 145 and #146
Proposed resolution: Close api #143 as resolved by api PR #145 and #146 (Rob Sanderson)
Rob Sanderson: +1
Ivan Herman: +1
Ruben Taelman: +1
Gregg Kellogg: +1
Adam Soroka: +1
Pierre-Antoine Champin: +1
Benjamin Young: +1
Dave Longley: +1
Resolution #2: Close api #143 as resolved by api PR #145 and #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compacting graph container with multiple nodes broken

3 participants