Update Create Term Definition to set defined[term] to true in 16.5. #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchampin
approved these changes
Dec 19, 2019
davidlehn
reviewed
Dec 19, 2019
| @@ -6901,6 +6909,10 @@ <h2>Changes since Candidate Release of 12 December 2019</h2> | |||
| <a href="#expansion-algorithm">Expansion algorithm</a> | |||
| that duplicate the following step. | |||
| This is in response to <a href="https://github.com/w3c/json-ld-api/issues/243">Issue 243</a>.</li> | |||
| <li>Updated step <a href="#ctd-contains-colon">16.5</a> of the | |||
There was a problem hiding this comment.
For all these CR change notes, I'm guessing the hard coded section numbers are ok because this whole section will be dropped anyway?
There was a problem hiding this comment.
Well, I'm counting on minimal changes to step numbering; the section numbering should be taken care of automatically. It would be great if there were some automated way to either insert the step number, or check it. But, if we do make further changes, we'll need to look at this section for future changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #245.
Preview | Diff