Skip to content

Update Create Term Definition to set defined[term] to true in 16.5. #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Update Create Term Definition to set defined[term] to true in 16.5. #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1642,16 +1642,24 @@ <h3>Algorithm</h3>
error has been detected and processing is aborted; if it equals <code>@context</code>, an
<a data-link-for="JsonLdErrorCode">invalid keyword alias</a>
error has been detected and processing is aborted.</li>
<li class="changed">If the <var>term</var> contains a colon (`:`)
<li id="ctd-contains-colon" class="changed">If the <var>term</var> contains a colon (`:`)
anywhere but as the first or last character of <var>term</var>,
or if it contains a slash (`/`) anywhere,
and for either case, the result of expanding <var>term</var>
using the <a href="#iri-expansion">IRI Expansion algorithm</a>, passing
<var>active context</var>, <var>term</var> for <var>value</var>, <code>true</code> for <var>vocab</var>,
<var>local context</var>, and <var>defined</var>,
is not the same as the <a>IRI mapping</a> of <var>definition</var>,
an <a data-link-for="JsonLdErrorCode">invalid IRI mapping</a>
error has been detected and processing is aborted.</li>
or if it contains a slash (`/`) anywhere:
<ol>
<li>Set the value associated with <var>defined</var>'s <var>term</var> <a>entry</a> to
<code>true</code>.</li>
<li>If the result of expanding <var>term</var>
using the <a href="#iri-expansion">IRI Expansion algorithm</a>,
passing <var>active context</var>,
<var>term</var> for <var>value</var>,
<code>true</code> for <var>vocab</var>,
<var>local context</var>,
and <var>defined</var>,
is not the same as the <a>IRI mapping</a> of <var>definition</var>,
an <a data-link-for="JsonLdErrorCode">invalid IRI mapping</a>
error has been detected and processing is aborted.</li>
</ol>
</li>
<li class="changed">If <var>term</var> contains neither a colon (`:`) nor a slash (`/`),
<span class="changed"><var>simple term</var> is <code>true</code></span>,
and if the <a>IRI mapping</a> of <var>definition</var>
Expand Down Expand Up @@ -6901,6 +6909,10 @@ <h2>Changes since Candidate Release of 12 December 2019</h2>
<a href="#expansion-algorithm">Expansion algorithm</a>
that duplicate the following step.
This is in response to <a href="https://github.com/w3c/json-ld-api/issues/243">Issue 243</a>.</li>
<li>Updated step <a href="#ctd-contains-colon">16.5</a> of the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all these CR change notes, I'm guessing the hard coded section numbers are ok because this whole section will be dropped anyway?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I'm counting on minimal changes to step numbering; the section numbering should be taken care of automatically. It would be great if there were some automated way to either insert the step number, or check it. But, if we do make further changes, we'll need to look at this section for future changes.

<a href="#create-term-definition">Create Term Definition algorithm</a>
to prevent an issue where <var>term</var> might not be defined at the time it is expanded.
This is in response to <a href="https://github.com/w3c/json-ld-api/issues/245">Issue 245</a>.</li>
</ul>
</section>

Expand Down