Add toRdf test for protected term override in prop-scoped context #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rubensworks does this match an existing expansion test? |
gkellogg
approved these changes
Mar 16, 2020
|
@gkellogg No, I could not find a directly corresponding test (but I am not 100% certain, since there are quite a lot of expansion tests as well). |
|
I'll followup and add any tests that are necessary. I think you can make your branches in this repo, which makes cooperating on PRs easier. If not, @iherman can make that happen. |
|
It seems that pr01 does essentially the same test, which comes from expansion. |
gkellogg
reviewed
Mar 16, 2020
|
pr01 seems to be expecting an error, while the new test from this PR does not. Is there a corresponding test for this in #422? |
|
Indeed, I can't find one that does quite this, although I thought we have it covered. I'll add it to #422 with a duplicate for expansion. |
gkellogg
added a commit
that referenced
this pull request
Mar 17, 2020
gkellogg
added a commit
that referenced
this pull request
Mar 17, 2020
gkellogg
added a commit
that referenced
this pull request
Mar 17, 2020
|
Closed via #422. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appeared toRdf was missing a test for checking that protected terms can be overridden from property-scoped contexts.