Skip to content

More comprehensive synchronization of expand tests in toRdf #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 17, 2020

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Mar 16, 2020

  • Move all expand/e0xx files to expand/erxx to avoid namespace issues to toRdf/e0xx which come from expand/00xx.
  • toRdf versions of expand/er*
  • Remove toRdf/ee* tests which are redundant with er* tests.
  • Add expand/in07-9 tests to toRdf.
  • Add expand/li03-10 to toRdf.
  • Add expand/0124-5 as toRdf/e124-5.
  • Add tests emxx, enxx, and epxx from expand to toRdf.
  • Update HTML manifests.

This should make all expansion tests have equivalents in toRdf. Tests expand/0xxx are no toRdf/exxx. Old expand/e0xx tests are now expand/erxx and copied to toRdf.

Fixes PR #418.
Fixes PR #419.

I was going to avoid such hard duplication, but it's leading to too much confusion, and this establishes a naming scheme that should help keep things in order.

Copy link
Member

@rubensworks rubensworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new tests identify several bugs in my implementation, so that's great :-)

@gkellogg gkellogg merged commit 6822636 into master Mar 17, 2020
@gkellogg gkellogg deleted the toRdf-exxx branch March 17, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants