Skip to content

Relative vocab #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 15, 2019
Merged

Relative vocab #58

merged 5 commits into from
Jan 15, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Jan 9, 2019

This update spec and tests to allow any relative IRI as the value of @vocab, not just the empty string.

For w3c/json-ld-syntax#72.


Preview | Diff

@iherman
Copy link
Member

iherman commented Jan 12, 2019

This issue was discussed in a meeting.

  • RESOLVED: address security concerns related to relative URIs for @vocab in current PRs before closing #72
View the transcript Allow relative IRIs for @vocab
Benjamin Young: w3c/json-ld-syntax#72
syntax - w3c/json-ld-syntax#114
api - #58
Gregg Kellogg: when we decided to satisfy the need for using the base as the @vocab,
… I came up with the idea of using an empty string as @vocab.
… When I implemented it, what I ended up doing was resolve @vocab as a relative URI against the base.
… So why not allow that in the spec…
Ivan Herman: ship it! :-)
Gregg Kellogg: It is uncontroversial, as it does not change past behaviour.
… Now you can simply use @vocab: “#”, to use relative URIs everywhere.
Rob Sanderson: –> w3c/json-ld-syntax#72 (comment)
Rob Sanderson: is this the issue we discussed this during TPAC?
… if you set vocab to ../# and you had example.org/ns then you get example.org/ns../#
Gregg Kellogg: I have to improve the text to indicate when standard URI resolution is used, and when string concatenation is used
Proposed resolution: address security concerns related to relative URIs for @vocab in current PRs before closing #72 (Benjamin Young)
Ivan Herman: +1
Benjamin Young: +1
Ivan Herman: please close issue 72 when you clarify that and merge it.
Gregg Kellogg: +1
Rob Sanderson: +1
Ivan Herman: Let’s reduce the number of open issue
Pierre-Antoine Champin: +1
David I. Lehn: +1
Resolution #4: address security concerns related to relative URIs for @vocab in current PRs before closing #72
Simon Steyskal: +1

@gkellogg gkellogg merged commit 253b48c into master Jan 15, 2019
@vocab
Copy link

vocab commented Jan 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants