-
Notifications
You must be signed in to change notification settings - Fork 23
Update text on vocabulary mapping and @vocab
to allow relative IRIs
#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azaroth42
approved these changes
Jan 11, 2019
Some weird whitespace happening in example 25 for the Turtle:
Don't think that's intentional though. Thoughts? |
@BigBlueHat It seems to be an artifact of the diff view; it's okay in the source and in the normal preview. |
This issue was discussed in a meeting.
View the transcriptAllow relative IRIs for @vocabBenjamin Young: #72 syntax - #114 api - w3c/json-ld-api#58 Gregg Kellogg: when we decided to satisfy the need for using the base as the @vocab, … I came up with the idea of using an empty string as @vocab. … When I implemented it, what I ended up doing was resolve @vocab as a relative URI against the base. … So why not allow that in the spec… Ivan Herman: ship it! :-) Gregg Kellogg: It is uncontroversial, as it does not change past behaviour. … Now you can simply use @vocab: “#”, to use relative URIs everywhere. Rob Sanderson: –> #72 (comment) Rob Sanderson: is this the issue we discussed this during TPAC? … if you set vocab to ../# and you had example.org/ns then you get example.org/ns../# Gregg Kellogg: I have to improve the text to indicate when standard URI resolution is used, and when string concatenation is used Proposed resolution: address security concerns related to relative URIs for @vocab in current PRs before closing #72 (Benjamin Young) Ivan Herman: +1 Benjamin Young: +1 Ivan Herman: please close issue 72 when you clarify that and merge it. Gregg Kellogg: +1 Rob Sanderson: +1 Ivan Herman: Let’s reduce the number of open issue Pierre-Antoine Champin: +1 David I. Lehn: +1 Resolution #4: address security concerns related to relative URIs for @vocab in current PRs before closing #72 Simon Steyskal: +1 |
…, which are resolved relative to the `base IRI`. This subsumes the previous usage of allowing just the empty string.
… previous vocabulary base.
43dfbfb
to
1388a08
Compare
Latest changes fix #72. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which are resolved relative to the
base IRI
. This subsumes the previous usage of allowing just the empty string.This is for #72.
Preview | Diff