Skip to content

example 67 uses not best practice of node embedded context #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
azaroth42 opened this issue Sep 16, 2019 · 1 comment · Fixed by #265
Closed

example 67 uses not best practice of node embedded context #250

azaroth42 opened this issue Sep 16, 2019 · 1 comment · Fixed by #265

Comments

@azaroth42
Copy link
Contributor

And instead I think we would now recommend to use a scoped context, no?

{
  "@context": {
    ...
    "@language": "ja"
  },
  "name": "花澄",
  "details": {
    "@context": {
      "@language": null
    },
    "occupation": "Ninja"
  }
}

Would become

{
  "@context": {
    ...
    "details": {
      "@context": {
        "@language": null
      }
    },
    "@language": "ja"
  },
  "name": "花澄",
  "details": {
    "occupation": "Ninja"
  }
}

This pattern should at least be demonstrated, even if 67 isn't changed

@gkellogg
Copy link
Member

I don't know if we've said that embedded contexts aren't best practices, but I see no harm in updating the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants