Skip to content

Azaroth suggestions #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Sep 25, 2019
Merged

Azaroth suggestions #265

merged 33 commits into from
Sep 25, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Sep 24, 2019


Preview | Diff

@gkellogg
Copy link
Member Author

Actually, there are several more I'll add on to this PR tomorrow.

gkellogg added a commit to w3c/json-ld-wg that referenced this pull request Sep 24, 2019
@gkellogg
Copy link
Member Author

Still a couple of more to go.

@gkellogg
Copy link
Member Author

I'll do the rest in another PR.

@gkellogg gkellogg merged commit dbfd7c4 into master Sep 25, 2019
@gkellogg gkellogg deleted the azaroth-suggestions branch September 25, 2019 16:45
<span class="changed">The empty string `""` and strings that have the form
of a keyword (e.g., staring with `"@"`) must not be used as terms.
Strings that have the form of
an absolute IRI (e.g., containing a `":"`) should not be used as terms.</span></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings that [contain a colon] should not be used as terms.

Well, it is acceptable to have a term definition of the form "foaf:knows": {"@type": "@id"}.
Isn't foaf:knows a term in that case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, the key for a term definition is not necessarily a term. Slightly confusing, but ok :)

@gkellogg
Copy link
Member Author

We can probably improve things more, but yes, the key for an expanded definition my be an IRI, which can’t be a term.

@gkellogg
Copy link
Member Author

Perhaps we should update the context definition to say that keys can be noted keywords and strings treated as terms of IRIs. The values of which may be strings, interpreted as IRIs, or expanded term definitions, or words to that effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment