Skip to content

Add issue marker for rdf:JSON datatype. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Feb 19, 2023

The rdf:JSON datatype is originally defined in Section 10.2 The rdf:JSON Datatype in JSON-LD 1.1. This issue is to promote the definition to RDF Concepts (and RDF Schema) to keep it with the definition of other datatypes in the RDF namespace.

See also w3c/rdf-schema#7.

For #14.


Preview | Diff

@afs
Copy link
Contributor

afs commented Feb 20, 2023

Unclear - there seem to be two discussions on the location of rdf:JSON text -- w3c/rdf-schema#7.

@TallTed
Copy link
Member

TallTed commented Mar 16, 2023

I'd add markers for both discussions to relevant doc(s). These markers do not reflect any decision, including on whether work is to be done, only that discussion is taking place in a GitHub Issue.

@gkellogg
Copy link
Member Author

I'd add markers for both discussions to relevant doc(s). These markers do not reflect any decision, including on whether work is to be done, only that discussion is taking place in a GitHub Issue.

I update the issue description; is that what you're referring to? Or, are there other links you think are necessary. Similar changes should probably go in w3c/rdf-schema#7.

@gkellogg gkellogg added Editorial Errata management: this erratum is editorial spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) labels Mar 16, 2023
@TallTed
Copy link
Member

TallTed commented Mar 16, 2023

@gkellogg -- I had misread this as issue, not PR, #18. So I have some suggested changes...

The rdf:JSON datatype is originally defined in Section 10.2 The rdf:JSON Datatype in JSON-LD 1.1. This issue is to promote the definition to RDF Concepts (and RDF Schema) to keep it with the definition of other datatypes in the RDF namespace.

I would open a new issue on rdf-concepts (#14 is overflowing with rather unfocused discussion), with an initial comment of the following (revision of the above) --

The rdf:JSON datatype is originally defined in Section 10.2 The rdf:JSON Datatype in JSON-LD 1.1. This issue is to determine whether to promote that definition to RDF Concepts (and RDF Schema), which would bring it in line with the definition of other datatypes in the RDF namespace.

I would also update the initial comment in w3c/rdf-schema#7 to echo the above, slightly modified to make its focus rdf-schema rather than rdf-concepts.

Then, I would put issue markers in RDF Concepts and RDF Schema HTML documents, which markers refer back to the new rdf-concepts issue and to w3c/rdf-schema#7, respectively.

@gkellogg
Copy link
Member Author

I don't see the point in creating a new issue; instead, I updated the initial issue description as you suggested (preserving the original text lower down).

I'll leave it up to @domel to update w3c/rdf-schema#7.

Please consider suggesting edits to spec/index.html in this PR for any specific wording you'd like to see appear in the issue text.

@pfps pfps added the needs discussion Proposed for discussion in an upcoming meeting label Mar 23, 2023
@gkellogg gkellogg removed the Editorial Errata management: this erratum is editorial label Mar 23, 2023
@rdfguy rdfguy removed the needs discussion Proposed for discussion in an upcoming meeting label Apr 6, 2023
@gkellogg gkellogg requested review from hartig and pchampin April 6, 2023 20:38
@gkellogg
Copy link
Member Author

gkellogg commented Apr 6, 2023

Discussed on today's call, but for good form, co-editors should approve.

@gkellogg gkellogg merged commit 25680b6 into main Apr 10, 2023
@gkellogg gkellogg deleted the json-datatype-issue branch April 10, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants