Skip to content

VC.name term definition #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2023
Merged

VC.name term definition #1053

merged 1 commit into from
Mar 4, 2023

Conversation

nissimsan
Copy link
Contributor

"name" pointing at https://schema.org/description doesn't seem right.

"name" pointing at https://schema.org/description doesn't seem right.
@nissimsan nissimsan requested a review from msporny as a code owner February 23, 2023 02:23
@nissimsan
Copy link
Contributor Author

I connected github and w3c, so I think the ipr fail should be resolved now.

@w3cbot
Copy link

w3cbot commented Feb 23, 2023

iherman marked as non substantive for IPR from ash-nazg.

@jandrieu
Copy link
Contributor

Seems to me "name" should not be in the context file at all.

It's not part of the VCDM.

@OR13
Copy link
Contributor

OR13 commented Feb 24, 2023

@msporny
Copy link
Member

msporny commented Mar 4, 2023

Seems to me "name" should not be in the context file at all.

name became a part of the VCDM in PR #905 (with broad support). Implementers were struggling with being able to simply name and describe a credential using text. It was decided that schema.org's name and description were useful terms to do this and broadly applicable.

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nissimsan wrote:

"name" pointing at https://schema.org/description doesn't seem right.

Yes, good catch, I hit exactly this problem today while running some code and it puzzled me for a good 15 minutes before I saw the issue.

Thanks for the fix, @nissimsan !

@msporny msporny merged commit a7c97b0 into w3c:main Mar 4, 2023
@OR13 OR13 mentioned this pull request Apr 3, 2023
@nissimsan nissimsan deleted the patch-1 branch April 14, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants