fix name id #1073
fix name id #1073
Conversation
suutaku
requested review from
msporny,
OR13,
selfissued,
decentralgabe and
awoie
as code owners
|
iherman marked as non substantive for IPR from ash-nazg. |
index.html
Outdated
| "name": { | ||
| "@id": "https://schema.org/description", | ||
| "@id": "https://schema.org/name", | ||
| "@type": "http://www.w3.org/2001/XMLSchema#string" | ||
| }, |
There was a problem hiding this comment.
It seems this should just be:
"name": "https://schema.org/name",
There was a problem hiding this comment.
Yes, agree (and change applied).
|
hmm #1053 Feels like maybe a data-include would have been a better approach to this... Why is the whole context embedded in html? |
|
@OR13 wrote:
Good point, I had missed that this PR was updating the index.html (and had presumed it was updating the context). Commit 52030d3 uses data-include now. Commit 14beefb applies the parts of this PR that didn't make it into the base v2 JSON-LD context. That effectively processes this PR, so even though I'm closing this PR, the updates have been made to the spec and base JSON-LD Context. Thank you @suutaku for finding the issue.
During the v1.0 work, there were a number of people in the group that felt that directly embedding the context in the spec would give it more weight than referring to a file outside the spec (that might change). It also gave implementers a value that they could directly copy/paste, verify the hash of, and then embed in their software. Some were concerned that if the v1 context were modified/changed, that we wouldn't have a spec to refer back to with what the VCWG intended at the time (this viewpoint ignores the fact that we have source control). In practice, that file outside of the core spec didn't change, and perhaps there is no longer a need to have the context in the spec given that we have a hash for the URL at which it's published. I'd be supportive of removing it from the spec and just referring to it by hash (noting that the hash will need to be updated as we go into PR to ensure we lock the correct version in). |
typo
Preview | Diff