Skip to content

Request vp media type #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Request vp media type #1144

merged 1 commit into from
Jun 17, 2023

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Jun 7, 2023

Copy link
Contributor

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If VPs stay in the spec, then this lgtm.

@iherman
Copy link
Member

iherman commented Jun 8, 2023

The issue was discussed in a meeting on 2023-06-07

  • no resolutions were taken
View the transcript

1.2. JWT PRs.

Orie Steele: There are 2 new PRs on VC-JWT, 103 and 104.

See github pull request vc-jwt#103.

See github pull request vc-jwt#104.

Orie Steele: There are 2 new PRs on VC-JWT, 103 and 104.

See github pull request vc-data-model#1144.

Orie Steele: PRs up in the core data model 1144.

Phillip Long: pdl-ASU has joined #vcwg.

Joe Andrieu: Added a comment to 103. Would it be useful to reuse the pattern for VCs. A base media type plus securing?
… both securing mechanisms will need a payload with a common basis.

Dmitri Zagidulin: +1 Joe, I was wondering about that as well.

Orie Steele: correct, that is what it is doing.

Dave Longley: agrees it is following the same pattern.

Orie Steele: talking about confidence method in registry.

Dave Longley: +1 to adding confidence method to the reserved terms table + v2 context, sounds good.

Brent Zundel: 9 open PRs, please review and look thru them.
… moving on to final topic, issues.

Ted Thibodeau Jr.: suggest that we call out specific issues and PRs in agenda ahead of time.

Orie Steele: There are also several open PRs here: https://github.com/w3c/vc-status-list-2021/pulls which can be discussed.

@iherman
Copy link
Member

iherman commented Jun 14, 2023

The issue was discussed in a meeting on 2023-06-14

  • no resolutions were taken
View the transcript

1.3. Request vp media type (pr vc-data-model#1144)

See github pull request vc-data-model#1144.

Manu Sporny: pull 1144 adds a media type for vps.
… expect that to merge soon.

</p>

<p>
This media type can be used with credentials secured using an <a>external proof</a>.
Copy link
Member

@msporny msporny Jun 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This media type can be used with credentials secured using an <a>external proof</a>.
This media type can be used with credentials secured using an <a>external proof</a>.

Hmm, this looks wrong? Is this ("credentials" instead of "presentations") what we're trying to say? I'm going to merge this, but wondering if this is a copy-paste error. If so, @OR13, can you fix it in a future (editorial) PR?

@msporny
Copy link
Member

msporny commented Jun 17, 2023

Normative, multiple reviews, no changes requested, no objections, merging.

@msporny msporny merged commit 9fea3cc into main Jun 17, 2023
@msporny msporny deleted the feat/request-vp-media-type branch June 17, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants