Skip to content

Request registration of vp content type #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Jun 7, 2023

@jandrieu
Copy link
Contributor

jandrieu commented Jun 7, 2023

Shouldn't this follow the pattern we use for securing VCs? With a base media type for VPs.

@iherman
Copy link
Member

iherman commented Jun 8, 2023

The issue was discussed in a meeting on 2023-06-07

  • no resolutions were taken
View the transcript

1.2. JWT PRs.

Orie Steele: There are 2 new PRs on VC-JWT, 103 and 104.

See github pull request vc-jwt#103.

See github pull request vc-jwt#104.

Orie Steele: There are 2 new PRs on VC-JWT, 103 and 104.

See github pull request vc-data-model#1144.

Orie Steele: PRs up in the core data model 1144.

Phillip Long: pdl-ASU has joined #vcwg.

Joe Andrieu: Added a comment to 103. Would it be useful to reuse the pattern for VCs. A base media type plus securing?
… both securing mechanisms will need a payload with a common basis.

Dmitri Zagidulin: +1 Joe, I was wondering about that as well.

Orie Steele: correct, that is what it is doing.

Dave Longley: agrees it is following the same pattern.

Orie Steele: talking about confidence method in registry.

Dave Longley: +1 to adding confidence method to the reserved terms table + v2 context, sounds good.

Brent Zundel: 9 open PRs, please review and look thru them.
… moving on to final topic, issues.

Ted Thibodeau Jr.: suggest that we call out specific issues and PRs in agenda ahead of time.

Orie Steele: There are also several open PRs here: https://github.com/w3c/vc-status-list-2021/pulls which can be discussed.

@OR13
Copy link
Contributor Author

OR13 commented Jun 9, 2023

@jandrieu as we discussed on the call, this approach does align with the approach we took previously:

application/vp+ld+jwt

See w3c/vc-data-model#1144

@jandrieu
Copy link
Contributor

@jandrieu as we discussed on the call, this approach does align with the approach we took previously:

application/vp+ld+jwt

See w3c/vc-data-model#1144

Interesting.

I was expecting a base media type, e.g., application/vp+ld+json which would then be secured by JWT, DI, etc. which show up as 'application/vp+jwt', but I'm not seeing any reference to a base media type.

I do see that application/vp+ld+json is mentioned in the other PR you mention w3c/vc-data-model#1144, but application/vc+jwt and application/vp+ld+jwt do not use the same pattern.

If it were using the same pattern, I would expect application/vp-jwt which secures application/vp-ld-json just as application/vc+jwt secures application/vc+ld+json

@OR13
Copy link
Contributor Author

OR13 commented Jun 14, 2023

@jandrieu i don't think your suggestion would be following the convention we have so far.

We defined a JSON media type for VCs:

vc+ld+json we use vc+ld+jwt to secure it.

We define a JSON media type for VPs:

vp+ld+json we use vp+ld+jwt to secure it.

We don't use "-" because we are trying to leverage the multiple suffixes draft, that we hope will be an RFC one day.

+json+jwt would be redundant.

Hopefully the examples in the other PRs will make this clearer.

@mprorock mprorock merged commit a9dff60 into main Jun 14, 2023
@decentralgabe decentralgabe deleted the fix/iana-vp-request branch February 26, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants