-
Notifications
You must be signed in to change notification settings - Fork 115
Add base classes and fragment identifiers for vocabulary. #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to, in the same PR, make the changes on the vocabulary.yml file, too? For each of those classes a defined_by
statement should replace the comment field.... This would save us yet another PR/merge round.
(I can make a PR against this one if you prefer.)
Putting my money where my mouth is... I have created #1278 to do this. @msporny, if you are o.k. with this, the best would be to merge #1278 right away into this one, so that all the possible comments would be at one place. I just did not want to directly edit your PR. |
The issue was discussed in a meeting on 2023-09-14
View the transcript1.6. Add base classes and fragment identifiers for vocabulary. (pr vc-data-model#1272)See github pull request vc-data-model#1272. Brent Zundel: primarily editorial, raised a few days ago. Manu Sporny: Yes to all of that, just need to merge TallTed's changes. See github pull request vc-data-model#1278. Ivan Herman: For the record, I did 1278 yesterday. Manu Sporny: agree to merge on top of it. Brent Zundel: merged, back to 1272.
|
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Normative, multiple reviews, changes requested and made, no objections, merging. |
This PR attempts to address part of issue #1263 by defining base classes (and their anchors) in the VCDM specification.
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Sep 26, 2023, 8:39 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.