fix(loader.options): use this.query to retrieve options

[hitmands]

[#204] - follows guidelines https://medium.com/webpack/webpack-4-migration-guide-for-plugins-loaders-20a79b927202

[jsf-clabot]

All committers have signed the CLA.

[MoOx]

Could you try to fix tests?

[hitmands]

I did fix them, can we merge please?

[MoOx]

Sorry but this will require more work before this end up being merged.

Very sorry to say that but this PR is clearly far from what is required to support webpack 4, properly. You need to add webpack 4 at least in travis.yml and in package.json in dev deps.

This will pop out a lot of error related to the current way this loader has been tested among various versions of webpack.

I guess the easiest way is to decide to make a major bump in the version (2.x) and drop all other webpack version (this way, no mess with webpack 1, 2, node 4... and previous way of loading options (and most importantly the tests related to this).

[TheLarkInn]

@MoOx were you interested in forking into a "next" branch. This is typically the way we have handled the v4 migrations and blasting it off as a major version.

[MoOx]

I would more go to keep a stable branch and work on master. Anyway, I think a PR can do the trick. The work need to be done at once imo. Even if this single line seems to be enough (it don't in practise), we need to run tests on the proper version (and break retro compat if necessary + add a version matrix at the beginning of the readmy)

[hitmands]

I submitted this pr to provide a basic support for webpack 4.

[MoOx]

Yes, thanks for this.
But I tried locally to use webpack 4 and tests are completely broken. So we cannot ship this as it is imo.