-
-
Notifications
You must be signed in to change notification settings - Fork 121
fix #204 | get this.options.eslint without error #212
Conversation
936a39c
to
1e98e32
Compare
There's an error when users use node version that is under 6.
|
Look nice. |
@MoOx |
Thanks @wonism for this! |
Thanks can't wait till this goes out! =] |
fix #215 |
@wonism @MoOx Now that webpack 4.0.0 was released stable https://github.com/webpack/webpack/releases/tag/v4.0.0 - any chance we can get this out soon? |
The Webpack version change in .travis.yml needs to be corrected before merging (now that Webpack 4.0.0 is released). |
package.json
Outdated
@@ -23,14 +23,14 @@ | |||
"loader-utils": "^1.0.2", | |||
"object-assign": "^4.0.1", | |||
"object-hash": "^1.1.4", | |||
"rimraf": "^2.6.1" | |||
"rimraf": "^2.6.1", | |||
"webpack": "^4.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be added as a dep, just devDep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I forgot the flag when I install the webpack. I'll fix it :)
Thanks for the work |
Released in 2.0.0 |
#204