Skip to content
This repository was archived by the owner on Sep 28, 2020. It is now read-only.

fix #204 | get this.options.eslint without error #212

Merged
merged 6 commits into from
Feb 26, 2018

Conversation

wonism
Copy link
Contributor

@wonism wonism commented Feb 17, 2018

@jsf-clabot
Copy link

jsf-clabot commented Feb 17, 2018

CLA assistant check
All committers have signed the CLA.

@wonism wonism force-pushed the master branch 2 times, most recently from 936a39c to 1e98e32 Compare February 17, 2018 22:42
@wonism
Copy link
Contributor Author

wonism commented Feb 17, 2018

There's an error when users use node version that is under 6.
I suggest to remove this in .travis.yml.

$ yarn
yarn install v1.3.2
[1/4] Resolving packages...
[2/4] Fetching packages...
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=6.11.5".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@MoOx
Copy link
Contributor

MoOx commented Feb 18, 2018

Look nice.
What about removing support for older version to simplify the tests? See #210 (comment)

@wonism
Copy link
Contributor Author

wonism commented Feb 19, 2018

@MoOx
You mean stopping to support webpack v1?
Actually, I did't understand certainly.
If not, I will revert the commit.

@stnwk
Copy link

stnwk commented Feb 20, 2018

Thanks @wonism for this!

@theskillwithin
Copy link

Thanks can't wait till this goes out! =]

@rickbeerendonk
Copy link

rickbeerendonk commented Feb 25, 2018

fix #215

@stnwk
Copy link

stnwk commented Feb 25, 2018

@wonism @MoOx Now that webpack 4.0.0 was released stable https://github.com/webpack/webpack/releases/tag/v4.0.0 - any chance we can get this out soon?

@rickbeerendonk
Copy link

The Webpack version change in .travis.yml needs to be corrected before merging (now that Webpack 4.0.0 is released).

package.json Outdated
@@ -23,14 +23,14 @@
"loader-utils": "^1.0.2",
"object-assign": "^4.0.1",
"object-hash": "^1.1.4",
"rimraf": "^2.6.1"
"rimraf": "^2.6.1",
"webpack": "^4.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be added as a dep, just devDep

Copy link
Contributor Author

@wonism wonism Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I forgot the flag when I install the webpack. I'll fix it :)

@MoOx MoOx merged commit 80ba5a4 into webpack-contrib:master Feb 26, 2018
@MoOx
Copy link
Contributor

MoOx commented Feb 26, 2018

Thanks for the work

@MoOx
Copy link
Contributor

MoOx commented Feb 26, 2018

Released in 2.0.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants