typing fixes #235
Merged
typing fixes #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@dcherian , finally all green! :) |
dcherian
reviewed
Jun 22, 2023
Comment on lines
+331
to
+342
|
|
||
| expect1: T_ExpectOpt | ||
| if expect is None: | ||
| if isbin_: | ||
| raise ValueError( | ||
| f"Please provided bin edges for group variable {idx} " | ||
| f"named {group_name} in expected_groups." | ||
| ) | ||
| expect_ = _get_expected_groups(b_.data, sort=sort) | ||
| expect1 = _get_expected_groups(b_.data, sort=sort) | ||
| else: | ||
| expect_ = expect | ||
| expect_index = _convert_expected_groups_to_index((expect_,), (isbin_,), sort=sort)[0] | ||
| expect1 = expect | ||
| expect_index = _convert_expected_groups_to_index((expect1,), (isbin_,), sort=sort)[0] |
There was a problem hiding this comment.
Prefer expect_ to expect1
There was a problem hiding this comment.
I found using numbers were much easier to read when you had multiple expect with varying types:
expect1 similar readabilty to expect_
expect2 much easier to read than expect__.
This reverts commit 8e55d3a.
…if it has been narrowed down.
dcherian
reviewed
Jul 3, 2023
dcherian
added a commit
that referenced
this pull request
Sep 28, 2023
* main: (68 commits) convert datetime: micro-optimizations (#261) compatibility with `numpy>=2.0` (#257) replace the deprecated `provision-with-micromamba` with `setup-micromamba` (#258) Fix some typing errors in asv_bench and tests (#253) [pre-commit.ci] pre-commit autoupdate (#250) typing fixes (#235) Fix test failure on i386 (#248) Delete resample_reduce (#246) Bump codecov/codecov-action from 3.1.3 to 3.1.4 (#243) Enable nanargmax, nanargmin (#171) Support nanfirst, nanlast with simple combine algo (#240) Check method only for dask reductions. (#241) Optimize broadcasting (#230) Handle min_count=0 (#238) Try and fix dtypes on 3.8,3.10 windows Preserve input dtypes now that pandas can do it. Add pytest-pretty to envs factorize early as much as possible Bump codecov/codecov-action from 3.1.1 to 3.1.3 (#239) [pre-commit.ci] pre-commit autoupdate (#229) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer version of mypy has found new issues with the typing.