Skip to content

compatibility with numpy>=2.0 #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2023
Merged

compatibility with numpy>=2.0 #257

merged 3 commits into from
Aug 31, 2023

Conversation

keewis
Copy link
Contributor

@keewis keewis commented Aug 28, 2023

numpy version 2 will introduce a few breaking changes, one of which flox inherited from xarray: the use of np.unicode_ instead of np.str_.

Edit: the mypy error should be unrelated
Edit2: this is currently blocking pydata/xarray#8117 (as noted there: numpy appears to be a bit unstable as they prepare for the 2.0 release, so not sure how quickly we need to adapt)

@dcherian dcherian merged commit bf49017 into xarray-contrib:main Aug 31, 2023
@keewis keewis deleted the numpy-2 branch September 9, 2023 19:14
dcherian added a commit that referenced this pull request Sep 28, 2023
* main: (68 commits)
  convert datetime: micro-optimizations (#261)
  compatibility with `numpy>=2.0` (#257)
  replace the deprecated `provision-with-micromamba` with `setup-micromamba` (#258)
  Fix some typing errors in asv_bench and tests (#253)
  [pre-commit.ci] pre-commit autoupdate (#250)
  typing fixes (#235)
  Fix test failure on i386 (#248)
  Delete resample_reduce (#246)
  Bump codecov/codecov-action from 3.1.3 to 3.1.4 (#243)
  Enable nanargmax, nanargmin (#171)
  Support nanfirst, nanlast with simple combine algo (#240)
  Check method only for dask reductions. (#241)
  Optimize broadcasting (#230)
  Handle min_count=0 (#238)
  Try and fix dtypes on 3.8,3.10 windows
  Preserve input dtypes now that pandas can do it.
  Add pytest-pretty to envs
  factorize early as much as possible
  Bump codecov/codecov-action from 3.1.1 to 3.1.3 (#239)
  [pre-commit.ci] pre-commit autoupdate (#229)
  ...
dcherian added a commit that referenced this pull request Nov 3, 2023
* main: (24 commits)
  Add `packaging` as dependency
  use engine flox for ordered groups (#266)
  Update pyproject.toml: py3.12
  Bump numpy to >=1.22 (#278)
  Cleanups (#276)
  benchmarks updates (#273)
  repo-review comments (#270)
  Significantly faster cohorts detection. (#272)
  Add engine="numbagg" (#72)
  Support quantile, median, mode with method="blockwise". (#269)
  Add multidimensional binning demo (#203)
  [pre-commit.ci] pre-commit autoupdate (#268)
  Drop python 3.8, test python 3.11 (#209)
  tests: move xfail out of functions (#265)
  Bump actions/checkout from 3 to 4 (#267)
  convert datetime: micro-optimizations (#261)
  compatibility with `numpy>=2.0` (#257)
  replace the deprecated `provision-with-micromamba` with `setup-micromamba` (#258)
  Fix some typing errors in asv_bench and tests (#253)
  [pre-commit.ci] pre-commit autoupdate (#250)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants