fire onSelectionChange on empty selection#3215
Merged
Tyriar merged 2 commits intoxtermjs:masterfrom Jan 15, 2021
Merged
Conversation
Fire the onSelectionChange event when a selection is cleared by single-clicking somewhere inside the terminal area. fixes xtermjs#3193. This also slightly changes the behaviour when re-selecting the same area in the terminal. Before, this fired onSelectionChange, but it does not anymore, even when changing the direction of the selection.
Co-authored-by: Megan Rogge <merogge@microsoft.com>
Tyriar
approved these changes
Jan 15, 2021
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Thanks for the fix and for finding the other bug 🙂
marvinthepa
commented
Jan 20, 2021
marvinthepa
commented
Jan 20, 2021
This was referenced Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fire the onSelectionChange event when a selection is cleared by
single-clicking somewhere inside the terminal area.
fixes #3193.
This also slightly changes the behaviour when re-selecting the same area
in the terminal. Before, this fired onSelectionChange, but it does not
anymore, even when changing the direction of the selection.