Skip to content

fire onSelectionChange on empty selection #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyriar merged 2 commits into from
Jan 15, 2021
Merged

fire onSelectionChange on empty selection #3215

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cb38cf
fire onSelectionChange on empty selection
marvinthepa Jan 14, 2021
66c80d8
Simplify checks
Tyriar Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/browser/services/SelectionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,16 +690,26 @@ export class SelectionService extends Disposable implements ISelectionService {
}

private _fireIfSelectionChanged(): void {
// Fire if there is no selection
const hasSelection = this.hasSelection;
if (!hasSelection && !this._oldHasSelection) {
if (!hasSelection) {
if (this._oldHasSelection) {
this._onSelectionChange.fire();
Comment thread
marvinthepa marked this conversation as resolved.
}
return;
}

const start = this._model.finalSelectionStart;
const end = this._model.finalSelectionEnd;

if (start?.[0] !== this._oldSelectionStart?.[0] || start?.[1] !== this._oldSelectionStart?.[1] ||
end?.[0] !== this._oldSelectionEnd?.[0] || end?.[1] !== this._oldSelectionEnd?.[1]) {
// Sanity check, these should not be undefined as there is a selection
if (!start || !end) {
return;
}

if (!this._oldSelectionStart || !this._oldSelectionEnd || (
Comment thread
marvinthepa marked this conversation as resolved.
start[0] !== this._oldSelectionStart[0] || start[1] !== this._oldSelectionStart[1] ||
end[0] !== this._oldSelectionEnd[0] || end[1] !== this._oldSelectionEnd[1])) {

this._oldSelectionStart = start;
this._oldSelectionEnd = end;
Expand Down