[Bug?]: `yarn version <version>` doesn't work when the version jump isn't major/minor/patch/prerelease/decline

[paul-soporan]

Self-service

• I'd be willing to implement a fix

Describe the bug

See title and the reproduction below.

Originally reported by @vefydwy in #3278.

To reproduce

await packageJsonAndInstall({
  version: `0.0.0`,
});

await expect(yarn(`version`, `2.0.0`))
  .resolves.toBeTruthy();

Environment

  System:
    OS: Linux 5.13 Arch Linux
    CPU: (32) x64 AMD Ryzen 9 5950X 16-Core Processor
  Binaries:
    Node: 16.0.0 - /tmp/xfs-049440fa/node
    Yarn: 3.0.1.dev - /tmp/xfs-049440fa/yarn
    npm: 7.10.0 - ~/.nvm/versions/node/v16.0.0/bin/npm

Additional context

Broken by #3158.

[yarnbot]

This issue reproduces on master:

Error: expect(received).resolves.toBeTruthy()

Received promise rejected instead of resolved
Rejected to value: [Error: Command failed: /usr/bin/node /github/workspace/scripts/actions/../run-yarn.js version 2.0.0

➤ YN0001: UsageError: Invalid value for enumeration: "2.0.0" (expected one of "decline", "major", "minor", "patch", "prerelease")
    at Object.validateEnum (/github/workspace/packages/yarnpkg-core/sources/miscUtils.ts:29:11)
    at validateReleaseDecision (/github/workspace/packages/plugin-version/sources/versionUtils.ts:24:20)
    at Object.resolveVersionFiles (/github/workspace/packages/plugin-version/sources/versionUtils.ts:147:59)
    at /github/workspace/packages/plugin-version/sources/commands/version/apply.ts:80:27
    at Function.start (/github/workspace/packages/yarnpkg-core/sources/StreamReport.ts:131:7)
    at VersionApplyCommand.execute (/github/workspace/packages/plugin-version/sources/commands/version/apply.ts:71:25)
    at VersionApplyCommand.validateAndExecute (/github/workspace/.yarn/__virtual__/clipanion-virtual-9c0fe9ed2d/0/cache/clipanion-npm-3.0.1-901533eeed-3a4b0c1e7d.zip/node_modules/clipanion/lib/advanced/Command.js:64:26)
    at Cli.run (/github/workspace/.yarn/__virtual__/clipanion-virtual-9c0fe9ed2d/0/cache/clipanion-npm-3.0.1-901533eeed-3a4b0c1e7d.zip/node_modules/clipanion/lib/advanced/Cli.js:132:24)
    at VersionCommand.execute (/github/workspace/packages/plugin-version/sources/commands/version.ts:111:14)
    at VersionCommand.validateAndExecute (/github/workspace/.yarn/__virtual__/clipanion-virtual-9c0fe9ed2d/0/cache/clipanion-npm-3.0.1-901533eeed-3a4b0c1e7d.zip/node_modules/clipanion/lib/advanced/Command.js:64:26)
➤ YN0000: Failed with errors in 0s 69ms
]
    at expect (/github/workspace/.yarn/cache/expect-npm-24.8.0-8c7640c562-0c0da74930.zip/node_modules/expect/build/index.js:138:15)
    at module.exports (evalmachine.<anonymous>:6:7)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async /github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.2-91650a2501-627bee24a7.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:56:13
    at async executeInTempDirectory (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.2-91650a2501-627bee24a7.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:17:16)
    at async Object.executeRepro (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.2-91650a2501-627bee24a7.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:24:12)
    at async ExecCommand.execute (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.2-91650a2501-627bee24a7.zip/node_modules/@arcanis/sherlock/lib/commands/exec.js:25:38)
    at async ExecCommand.validateAndExecute (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-91cf93ba72.zip/node_modules/clipanion/lib/advanced/Command.js:161:26)
    at async Cli.run (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-91cf93ba72.zip/node_modules/clipanion/lib/advanced/Cli.js:74:24)
    at async Cli.runExit (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-91cf93ba72.zip/node_modules/clipanion/lib/advanced/Cli.js:83:28)

[danielmahon]

Also just came across a weird bug (cache?) where the version command holds onto the previous failed state:

lvt [main|✚ 18…20] > yarn version 0.0.20
Usage Error: Invalid value for enumeration: "0.0.20" (expected one of "decline", "major", "minor", "patch", "prerelease")

$ yarn version [-d,--deferred] [-i,--immediate] <strategy>
lvt [main|✚ 18…20] > yarn version prerelease
Usage Error: Invalid value for enumeration: "0.0.20" (expected one of "decline", "major", "minor", "patch", "prerelease")

$ yarn version [-d,--deferred] [-i,--immediate] <strategy>
lvt [main|✚ 18…20] > yarn version patch
Usage Error: Invalid value for enumeration: "0.0.20" (expected one of "decline", "major", "minor", "patch", "prerelease")

Looks like it's holding onto that at .yarn/versions/[hash].yml

releases:
  project: 0.0.20

undecided:
  - "project/app"
  - "project/server"

removing that file frees up the command again

[Haemoglobin]

Hi - when will this fix be available by running "yarn plugin import version" ? Seems it isn't there yet..

Thanks

[merceyz]

It's available in the latest canary builds

yarn set version canary && yarn plugin import version

[Haemoglobin]

It's available in the latest canary builds

yarn set version canary && yarn plugin import version

Works, thanks for your prompt reply!

[rxliuli]

Currently the latest version of yarn and version plug-ins still have this problem, and all the sub-commands cannot be used anymore

yarn version: 3.0.2

$ yarn version patch
Usage Error: Invalid value for enumeration: "0.1.0" (expected one of "decline", "major", "minor", "patch", "prerelease")

$ yarn version [-d,--deferred] [-i,--immediate] <strategy>

[vefydwy]

Currently the latest version of yarn and version plug-ins still have this problem, and all the sub-commands cannot be used anymore

yarn version: 3.0.2

$ yarn version patch
Usage Error: Invalid value for enumeration: "0.1.0" (expected one of "decline", "major", "minor", "patch", "prerelease")

$ yarn version [-d,--deferred] [-i,--immediate] <strategy>

As already mentioned above, you have to migrate/upgrade from yarn berry to yarn canary. Not sure if this fix will ever come for yarn v3.0.x or only for v3.1.x. Not even sure if v3.0.x is still an active branch or if all further development and bugfixing will happen on v3.1.x and above.

TBH I don't understand the latest version steps done in yarn. Versions between v2.x and v3.0.2 are called "berry" whereas versions from v3.1.x onwards seem to be called "canary".

Until these versions and version names become a bit more stable (or at least a bit more clear for us) we will stay at v2.4.2 and a versions-plugin snapshot which does not have this problem. Until now this combination is working quite stable and we haven't faced any issues until now. So there is no need for us to switch to any newer versions.

Also the last (as of now) canary version (v3.1.0-rc.7) is not yet an official release but just a release candidate (at least it looks like so).

[arcanis]

• set version latest downloads the latest stable >2 if the current release you use is already >2, otherwise the latest 1.x (in other words it doesn't silently upgrade past 1.x, for backward compatibility)

• set version berry always downloads the latest stable version >2 (including by upgrading to higher majors)

• set version canary (new in 3.0) always downloads the latest release candidate.

The difference between stable and rc is very small - it's almost more a marketing difference than functional one, as all the tests need to pass whether it's one or the other. At Datadog we even use builds built straight from sources, for example.

[vefydwy]

• set version canary (new in 3.0) always downloads the latest release candidate.

But this seems to be introduced just recently as the version 2.4.2 which we still use doesn't know about "canary".

$ yarn --version
2.4.2

$ yarn set version canary
Usage Error: Invalid version descriptor "canary"

That's why I thought "canary" is the successor of "berry".

[arcanis]

Yes, that's what I said: canary is new in 3.x. Perhaps it'd be a good idea to backport it, I didn't think of that (we tend to keep backports for fixing really critical/annoying issues).