fix: validate strategies in version plugin and support ": decline" #3158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
reviewed
Jul 22, 2021
packages/acceptance-tests/pkg-tests-specs/sources/commands/version/apply.test.ts
Outdated
Show resolved
Hide resolved
arcanis
previously approved these changes
Jul 22, 2021
Member
arcanis
left a comment
arcanis
left a comment
There was a problem hiding this comment.
LGTM - I'd just change the 'package.json' as Filename.manifest
arcanis
approved these changes
Jul 22, 2021
3 tasks
1 task
| throw new Error(`Assertion failed: Invalid value for enumeration`); | ||
| const values = Object.values(def); | ||
|
|
||
| if (!values.includes(value as any)) |
There was a problem hiding this comment.
because of that, we can't apply a valid semver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
yarn version.: declinesyntaxHow did you fix it?
I also wanted to add tests testing manual modifications to the version files but I haven't managed to get them to work.
Checklist