feat(Storage): add columns setup #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
1216-storage-columns-setup
branch
2 times, most recently
from
a63e5e4 to
25ea35f
Compare
artemmufazalov
commented
Sep 19, 2024
| @@ -90,11 +89,6 @@ export const invertedDisksSetting: SettingProps = { | |||
| settingKey: INVERTED_DISKS_KEY, | |||
| title: i18n('settings.invertedDisks.title'), | |||
| }; | |||
| export const useAdvancedStorageSetting: SettingProps = { | |||
There was a problem hiding this comment.
Now user will be able to select desired columns view via columns setup
|
@artemmufazalov what do you think if we move column selector in Vdisk and Pdisk pages on a previous line like: 
|
I don't like the control on the tabs level, since it is connected to content of one tab and isn't connected to another - As for |
artemmufazalov
force-pushed
the
1216-storage-columns-setup
branch
from
25ea35f to
aa215a0
Compare
astandrik
approved these changes
Sep 23, 2024
Raubzeug
approved these changes
Sep 23, 2024
artemmufazalov
force-pushed
the
1216-storage-columns-setup
branch
from
4c1706e to
5e24996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1216, closes #1155
Add columns setup to Storage component, use Storage component on StorageGroup, PDisk and VDisk pages
Remove advanced storage setting, since VDisks with PDisks column could be selected in setup
Stand: https://nda.ya.ru/t/RkTCeA0U78MSpb
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔽
Current: 78.99 MB | Main: 79.01 MB
Diff: 0.02 MB (-0.03%)
✅ Bundle size decreased.
ℹ️ CI Information