feat: show vdisks of selected group in a special color #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
changed the title
artemmufazalov
requested changes
Sep 23, 2024
| @@ -172,6 +172,7 @@ export function StorageGroupPage() { | |||
| tableSettings={DEFAULT_TABLE_SETTINGS} | |||
| visibleEntities="all" | |||
| nodesUptimeFilter={NodesUptimeFilterValues.All} | |||
| additionalNodesProps={{groupId: groupId || undefined}} | |||
There was a problem hiding this comment.
It conflicts with usage single Storage component everywhere. If we will agree on it, your solution won't be valid. I suggest waiting until it's merged
astandrik
force-pushed
the
astandrik.show-vdisks-of-selected-group-1335
branch
from
8117076 to
e4a74b1
Compare
Raubzeug
previously approved these changes
Sep 24, 2024
src/containers/Storage/Storage.tsx
Outdated
| @@ -109,6 +109,7 @@ export const Storage = ({database, nodeId, groupId, pDiskId}: StorageProps) => { | |||
| additionalNodesProps, | |||
| visibleEntities, | |||
| database, | |||
| groupId: valueIsDefined(groupId) ? groupId.toString() : undefined, | |||
There was a problem hiding this comment.
groupId: groupId?.toString()
artemmufazalov
previously approved these changes
Sep 24, 2024
astandrik
dismissed stale reviews from artemmufazalov and Raubzeug
via
3e8b7e1
artemmufazalov
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1335
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: ✅
Current: 79.00 MB | Main: 79.00 MB
Diff: +0.00 MB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information