Repository navigation
feat: implement colored state labels for storage groups - #4458
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f79829a054
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Known state titles bypass the repository’s localization pattern.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds colored status labels for storage-group state and degradation data.
Changes:
- Parses group states into themed labels with focused tests.
- Reuses shared severity styling, including heavy-danger labels.
- Updates storage table rendering for state and degraded columns.
| File | Description |
|---|---|
src/utils/disks/constants.ts |
Adds heavy-danger severity metadata. |
src/containers/Storage/utils/getStorageGroupStateLabel.ts |
Parses states into label data. |
src/containers/Storage/utils/__test__/getStorageGroupStateLabel.test.ts |
Tests state parsing and styling. |
src/containers/Storage/PaginatedStorageGroupsTable/columns/columns.tsx |
Renders state and degradation labels. |
src/components/VDiskStatus/statuses.ts |
Reads heavy-danger styling from shared configuration. |
src/components/PDiskInfo/statuses.ts |
Uses shared label visual configuration. |
src/components/DiskStatus/DiskStatus.tsx |
Supports labels with a required title and optional value. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@astandrik, Would you be okay with parsing this format on the frontend? Backend PR #55274 adds structured |
|
@kkdras, давай сразу добавим чтение Для fallback важно разбирать фактический формат |
|
@astandrik, I've created #4469 as a follow-up to add We can keep the current implementation in this PR and proceed with the review without waiting for the backend rollout. |
astandrik
left a comment
astandrik
left a comment
There was a problem hiding this comment.
Проверено:
- Разбор State по backend-контракту: mirror-3-dc, детали в скобках, пустые и неизвестные состояния.
- 50 unit-тестов и embedded-сборки base/head — прошли.
- 15 состояний в Chromium/WebKit на mock API, светлая и тёмная темы. CI зелёный; 5 E2E прошли после retry.
Неблокирующее замечание: новый бейдж Missing Disks не помещается в стандартную ширину колонки и получает лишнее многоточие. Стоит увеличить width и resizeMinWidth.
StateInfo оставляем для #4469.
Resolves #4436
Stand (frontend mocks)
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 65.30 MB | Main: 65.30 MB
Diff: +4.38 KB (0.01%)
ℹ️ CI Information
The PR appears safe to merge; the reviewed changes leave no outstanding finding.
What we checked:
Summary
Storage group states now appear as colored labels with their details, making them easier to scan. The separate Degraded column also uses the shared disk-status label style.
Reviews (3) · Last reviewed commit: "fix(storage): clarify state label data a..."