Move more helper functions to -lib, cleanup scripts #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If you want 37 pieces of flair, why don't you just make that the minimum? |
zdykstra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the helper functions from zfsbootmenu-help.sh:
zfsbootmenu-preview.shhad a lot of legacy code / procedures in it, beforezfsbootmenu-lib.shwas as fleshed out as it is now. Clean up the usage / flow dramatically to use helper functions where possible.zfs-chroot.shnow colorizes text when entering the chroot to add 37 pieces of flair to the output.timed_prompt,resume_prompt, and the snapshot manipulation user input sections inzfsbootmenu.shcould possibly use an update to usecolorize- but with the possible future use ofdialog, that might be wasted effort. Thoughts?Closes #115