#616: deduplicate repos matched by overlapping masks in unmask_repos#618
Open
morphqdd wants to merge 1 commit into
Open
#616: deduplicate repos matched by overlapping masks in unmask_repos#618morphqdd wants to merge 1 commit into
morphqdd wants to merge 1 commit into
Conversation
Contributor
Author
|
@yegor256, please take a look when you have a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #616.
Fbe.unmask_reposappended matches from every inclusion mask independently, so a repository matched by both an exact-name mask and a wildcard mask (e.g.yegor256/factbase,Yegor256/*) survived to the final list twice and was yielded — and processed — twice per run. Arepos.uniq!now runs right after the exclusion pass, before the archived-repos filter, so duplicates also don't cost an extraocto.repositorycall each.The new test reproduces the overlap from the issue and asserts the list is duplicate-free while still containing the doubly-matched repo; it fails on master.
Tests: 13 tests, 0 failures; rubocop: no offenses.