Skip to content

#616: deduplicate repos matched by overlapping masks in unmask_repos #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morphqdd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#616: deduplicate repos matched by overlapping masks in unmask_repos #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/fbe/unmask_repos.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def Fbe.unmask_repos( # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticCompl
re = Fbe.mask_to_regex(mask[1..])
repos.reject! { |r| re.match?(r) }
end
repos.uniq!
repos.reject! { |repo| octo.repository(repo)[:archived] }
raise(Fbe::Error, "No repos found matching: #{options.repositories.inspect}") if repos.empty?
repos.shuffle!
Expand Down
7 changes: 7 additions & 0 deletions test/fbe/test_unmask_repos.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ def test_finds_case_insensitive
assert_equal(2, list.size)
end

def test_deduplicates_repos_matched_by_overlapping_masks
opts = Judges::Options.new({ 'testing' => true, 'repositories' => 'yegor256/factbase,Yegor256/*' })
list = Fbe.unmask_repos(options: opts, global: {}, loog: Loog::NULL)
assert_equal(list.uniq.size, list.size, "duplicates found in #{list.inspect}")
assert_includes(list, 'yegor256/factbase')
end

def test_mask_to_regex_treats_dot_as_literal
re = Fbe.mask_to_regex('zold-io/blog.zold.io')
assert_match(re, 'zold-io/blog.zold.io')
Expand Down
Loading