-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Feature: shell tap command
#1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b5da4fe to
fb5ae21
Compare
|
This is great, thanks! I've tested it and would be happy for it to be merged now. Suggestions for future work:
|
I added some instructions for that here: caksoylar/zmk-posix-testbed@e55dd85 However since it didn't work on my system there might be issues. I'd welcome any fixes if there is an issue with the instructions! |
Thanks for adding those instructions. Accessing the shell on native POSIX through a pty and using usbip works for me on Linux, apart from #1444, although I did have to manually load modules and some commands require root. But by accessing the shell over USB, I mean enabling the shell on a physical ZMK MCU board directly connected to the host via USB, and accessing the shell via CDC_ACM in the same way as can be done now with USB logging. It may just require adding https://github.com/zephyrproject-rtos/zephyr/blob/main/samples/subsys/shell/shell_module/overlay-usb.conf and https://github.com/zephyrproject-rtos/zephyr/blob/main/samples/subsys/shell/shell_module/usb.overlay but I haven't tried that yet. |
|
I have a working shield with shell over CDC_ACM now, will share after some cleanup. |
|
I've made something like KMonad using this PR. See manna-harbour/xmk#2. |
|
Hello, https://gist.github.com/instance-id/f52b8efbea082f08de06d08cfe7bb504 Also, if this is not the appropriate place to pose this question, please do let me know and I will remove it and relocate it to the specified location. |
fb5ae21 to
debca7a
Compare
debca7a to
0b3f194
Compare
0b3f194 to
2a50d8d
Compare
2a50d8d to
2b6e489
Compare
* Allow tap/press/release of a given key position within the Zephyr shell.
* By default, don't generate any events for the native posix board DTS, to allow native builds outside of the testing use case.
2b6e489 to
a386359
Compare
|
This PR has been automatically marked as stale because it has not had activity in 10 months. It will be closed in 14 days if no further activity occurs. Feel free to give a status update or re-open when it has been rebased and is ready for review (again). Thanks! |
|
This PR was closed because it had no activity for over 10 months. Feel free to give a status update or re-open when it has been rebased and is ready for review (again). |
Initial work on making the Zephyr Shell useful for ZMK.
SENSORto not force it on all the time, which helps fornative_posix_64target builds.*Minor native_posix_64 tweaks to allow building without any simulated kscan events, since we will use the shell for that instead.
key tap 0to generate press then release of the 0th key position.This is useful for building a native posix executable to test ZMK by hand, generate key events, test changes to USB via the USB IP native driver, etc.