Skip to content

Date separators #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnprice opened this issue Jun 9, 2023 · 3 comments · Fixed by #469
Closed

Date separators #173

gnprice opened this issue Jun 9, 2023 · 3 comments · Fixed by #469
Assignees
Labels
a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for

Comments

@gnprice
Copy link
Member

gnprice commented Jun 9, 2023

When successive messages span a date boundary, we should show a separator indicating the new date, like in Zulip web and zulip-mobile.

This complements the dates in recipient headers (#172) by highlighting when the answer changes. (Plus, when we start properly suppressing repeat recipient headers, it makes it possible to do so spanning dates without becoming misleading.)

@gnprice gnprice added the a-msglist The message-list screen, except what's label:a-content label Jun 9, 2023
@gnprice gnprice added this to the Beta milestone Jun 9, 2023
@gnprice
Copy link
Member Author

gnprice commented Sep 22, 2023

In the implementation we merged for #174, we effectively included date separators by having there be a new recipient header when the date changes (even if the recipient didn't).

It'd still be nice to have a distinct design for purely separating dates, like we do in Zulip web and zulip-mobile.

@gnprice gnprice modified the milestones: Beta, Launch Sep 22, 2023
@gnprice gnprice modified the milestones: Launch, Beta 2 Dec 19, 2023
@gnprice
Copy link
Member Author

gnprice commented Dec 19, 2023

Early beta feedback reports that our current stopgap use of additional recipient headers as date separators is "distracting":
https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Flutter.20feedback/near/1700169

So bumping up to Beta 2.

@gnprice gnprice added the beta feedback Things beta users have specifically asked for label Dec 23, 2023
@gnprice gnprice self-assigned this Dec 29, 2023
@gnprice
Copy link
Member Author

gnprice commented Dec 29, 2023

@terpimost I'm not finding any examples of date separators when I browse the existing Figma design. So I'll base this initially off of what's in web, but I'd be glad to adjust later if you have other thoughts.

gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jan 4, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 1, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 1, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 1, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 3, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 3, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 3, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 3, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 3, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 15, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 15, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 15, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 15, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 15, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 15, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 16, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 16, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 16, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 17, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 17, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 17, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 17, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 22, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 23, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 23, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 23, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 24, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 25, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 25, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 28, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue May 7, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when handling outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue May 7, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when processing items for outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue May 13, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when processing items for outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue May 13, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when processing items for outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue May 13, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when processing items for outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue May 14, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when processing items for outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue May 16, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when processing items for outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue May 19, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when processing items for outbox messages.
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue May 19, 2025
Also removed a stale comment that refers to resolved issues
(zulip#173 and zulip#175).

We will reuse this helper when processing items for outbox messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant