Skip to content

Date separators push sticky header off screen #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnprice opened this issue Jan 8, 2024 · 0 comments · Fixed by #480
Closed

Date separators push sticky header off screen #479

gnprice opened this issue Jan 8, 2024 · 0 comments · Fixed by #480
Labels
a-msglist The message-list screen, except what's label:a-content

Comments

@gnprice
Copy link
Member

gnprice commented Jan 8, 2024

When a date separator is scrolled near the top of the message list's viewport, it pushes the sticky header up off the top of the screen:
image

In other words it does the same thing that a new recipient header would do. (Once the date separator reaches the top of the viewport, though, the header reappears — this time the one provided by the date separator, so it looks the same as the old recipient header except for its date.)

But a date separator doesn't have all the information a recipient header does, so it doesn't replace the old recipient header and shouldn't push it off the screen. Instead, it should behave the same as a message, and let the preceding item's sticky header overlap into it.

This is a sort of followup to #173 / #469, where we introduced date separators in the first place.

@gnprice gnprice added the a-msglist The message-list screen, except what's label:a-content label Jan 8, 2024
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jan 8, 2024
@gnprice gnprice added this to the Beta 2 milestone Jan 8, 2024
@gnprice gnprice closed this as completed in 1674243 Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-msglist The message-list screen, except what's label:a-content
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant