Revert ios build workaround for Firebase packages #1388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
added
the
maintainer review
PIG208
reviewed
Mar 19, 2025
PIG208
added
integration review
gnprice
reviewed
Mar 20, 2025
There was a problem hiding this comment.
Thanks for cleaning this up!
Let's keep around the Zulip.xcconfig file and the bits of config that wire it up — it'll just become empty except for the general comment at top.
That way the next time there's some Xcode config we want to add, we have all the infrastructure in place to just drop it in that file and have it get applied. Effectively we'll get to re-use the work that we did in #958 to figure those details out.
rajveermalviya
force-pushed
the
pr-remove-ios-build-workaround
branch
from
7e64e82 to
623b8f1
Compare
|
Thanks for the review @gnprice! Pushed a new revision, PTAL. |
This reverts part of commit a9b2016 (zulip#958), keeping the `Zulip.xcconfig` file and its references. The fix was released in version `3.6.0` of `package:firebase_core` and version `15.1.3` of `package:firebase_messaging`: firebase/flutterfire@d7d2d4b We have since then updated Firebase dependencies 3 times: zulip@24215f6 zulip@1abb0a0 zulip@3ba9985
|
Thanks! Looks good; merging, with a few commit-message tweaks: (In particular, 'Revert "ios: …"' is no longer accurate because it's not reverting that whole commit.) |
gnprice
force-pushed
the
pr-remove-ios-build-workaround
branch
from
623b8f1 to
e3b274a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a9b2016.